#3001: IE : Automatically save the selection when loosing focus
----------------------+-----------------------------------------------------
  Reporter:  fredck   |       Owner:  fredck           
      Type:  Bug      |      Status:  closed           
  Priority:  High     |   Milestone:  CKEditor 3.0     
 Component:  General  |     Version:                   
Resolution:  fixed    |    Keywords:  Confirmed Review+
----------------------+-----------------------------------------------------

Comment(by fredck):

 Replying to [comment:7 garry.yao]:
 >  1. It's not necessary to have L132 of
 ''_source\plugins\selection\plugin.js'', since a saving will be fired by
 'selectchange' event at the moment;

 It's needed. I've found some cases where selectionchange don't get fired,
 or it's fired before the focus event, making the saving be missed.

 >  1. Within ''selectElement'' method L766, maybe the cached type should
 be 'CKEDITOR.SELECTION_ELEMENT' instead.

 Ok... I've thought about <span> elements and so on, but it makes sense to
 have the type as element. I've changed it when committing.

 >  1. Within ''selectRanges'' method L813, we can't leave
 'selectedElement' to null, otherwise later it will be retrieved from
 native selection, which is error prone.

 No problem to use "null". The cache checking is done using "!==
 undefined", which is "true" for "null.

 > also the 'type' and 'startElement' is not accurately calculated.

 Not a big issue for now. It would just make our code larger with not real
 benefits.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/3001#comment:10>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to