#1527: FCK class should have a function that returns FCKeditor version and
revision
-------------------------------+--------------------------------------------
 Reporter:  wwalc              |       Owner:  wwalc       
     Type:  New Feature        |      Status:  new         
 Priority:  Normal             |   Milestone:  CKEditor 3.0
Component:  General            |     Version:              
 Keywords:  Confirmed Review-  |  
-------------------------------+--------------------------------------------
Changes (by fredck):

  * keywords:  Confirmed Review? => Confirmed Review-


Comment:

 I didn't try the code, but the changes make sense.

 A few minor things:

  * In the trunk, we should have an special revision number, just like in
 FCKeditor. Right now, it should be called "CKEditor 3.0 SVN". The real
 name is set only when creating public releases. So, please change the
 releaser batch program with the following params:

 {{{
 "CKEditor 3.0 SVN" ckeditor_3.0_svn.zip ckeditor_3.0_svn.tar.gz
 }}}

  * Actually, you could even avoid having both the .zip and .tar.gz file
 names in the above line. Having only {{{'"CKEditor 3.0 SVN"
 ckeditor_3.0_svn'}}} would be enough, and that name would be used for both
 the .zip and .tar.gz files.

  * It's wrong to say "the CKEditor". It's a noun, and you should use only
 "CKEditor" ("version number of CKEditor"). Actually the documentation
 should say something like "Contains the CKEditor version number.". In this
 case "the" is not for "CKEditor", but for "version number".

 As said... just small details, but the code itself is ok.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/1527#comment:9>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to