#2885: Implement the div container command.
-------------------------------+--------------------------------------------
 Reporter:  martinkou          |       Owner:  martinkou      
     Type:  Task               |      Status:  new            
 Priority:  Normal             |   Milestone:  CKEditor 3.0   
Component:  General            |     Version:  SVN (FCKeditor)
 Keywords:  Confirmed Review-  |  
-------------------------------+--------------------------------------------
Changes (by fredck):

  * keywords:  Confirmed Review? => Confirmed Review-


Comment:

 * Why has the "cke_button_creatediv" button been defined in the
 toolbar.css file, while others have been properly defined in icons.css?

  * It misses the skin changes (icons) for the office2003 skin.

  * As already defined before, there should not be "default" values in the
 settings.

  * The "div" plugins requires "elementspath", but I can't understand the
 correlation between them.

  * The dialog is too big, with a lot of blank space at the bottom. Has it
 been tested at all?!

  * The getNonEmptyChildren doesn't look like a good addition to the API,
 and it's used by the div dialog only. It should be then moved to that
 dialog code as a private, instead on enlarging the CKEDITOR.dom.element
 class.

  * Instead of having CKEDITOR.dom.elementPath.pathBlockLimitElements, we
 should instead have CKEDITOR.dtd.$blockLimit at this point.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/2885#comment:11>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to