#2885: Implement the div container command.
-------------------------------+--------------------------------------------
Reporter: martinkou | Owner: martinkou
Type: Task | Status: new
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version: SVN (FCKeditor)
Keywords: Confirmed Review? |
-------------------------------+--------------------------------------------
Changes (by martinkou):
* keywords: Confirmed Review- => Confirmed Review?
Comment:
Point 1... I've thought about that a bit in the previous patch as well.
But I was worried whether it is still possible for empty div containers to
exist at that point. I need to prove that it's impossible for empty div
container to be there before deleting that block.
I've deleted that block of code in the new patch. My prove is as follows:
For each block group...
1. If the created div container had nothing, then L213 - L219 was never
executed for the current block group.
2. If L213 - L219 was never executed, then the current block group in
L205 contains no block.
3. But L291 guarantees that each block group will have at least one
block.
So L255 - L261 can be deleted.
Point 2... There's no need to copy the block of code from the list plugin.
With the current logic, as long as there's something in the document to
create div containers from, then at least one div container will be
created. I've noticed the applyDiv() function does not save the current
selection with bookmarks... So adding bookmarks for the current selection
position will fix both problems - it keeps the previous selection intact
after adding div containers, and it guarantees that at least one div will
be created even in an empty document.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2885#comment:22>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensign option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
