#3356: Ident problem with nested block
-------------------------------+--------------------------------------------
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version:
Keywords: Confirmed Review+ |
-------------------------------+--------------------------------------------
Changes (by martinkou):
* keywords: Confirmed Review? => Confirmed Review+
Comment:
The original commonParents code, ported from v2, was supposed to handle
case like this:
{{{
<div id="div1">
fdasjkfldasjkflsdadsa
<div id="div2">
jdaslfjlsa
<div id="div3">
fsdja
<div>
fdsjalkfjasdk
<div>
fdjaklfjasd</div>
lsdkflsadl</div>
fldjsklfjsadfsd</div>
fjdjdas </div>
fdjaskfldajkfsd </div>
}}}
The problem at that time was that the dom iterator would report div1 and
div2 and div3 as separate paragraphs. So indenting with div1 selected
would mean div1 is indented 40px, div2 is indented 40px + 40px = 80px and
div 3 is indented 40px * 3 = 120px.
Now this is no longer happening with the dom iterator, as the dom iterator
can now correctly separate the things between div1 and div2, and div2 and
div3 into new paragraphs. So it would make sense to ignore the common
parent node and indent them all. So it's correct to remove the common
parent checking logic.
Review+
--
Ticket URL: <http://dev.fckeditor.net/ticket/3356#comment:5>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations
Conference from O'Reilly Media. Velocity features a full day of
expert-led, hands-on workshops and two days of sessions from industry
leaders in dedicated Performance & Operations tracks. Use code vel09scf
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
