#3092: plugin:stylesCombo has no options
---------------------------------------+------------------------------------
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version: SVN (FCKeditor)
Keywords: Firefox Confirmed Review- |
---------------------------------------+------------------------------------
Changes (by fredck):
* keywords: Firefox Confirmed Review? => Firefox Confirmed Review-
Comment:
The idea is ok. There are two small optimizations that could be done in
the code, which are result of the change:
* As we may have the "element" variable, the elementPath creation should
consider it. So we could have the following at line 161:
{{{
elementPath = new CKEDITOR.dom.elementPath( element ||
selection.getStartElement() );
}}}
* As we now always have the elementPath variable created, the if check at
line 185 and its relative else block are not anymore needed.
--
Ticket URL: <http://dev.fckeditor.net/ticket/3092#comment:8>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations
Conference from O'Reilly Media. Velocity features a full day of
expert-led, hands-on workshops and two days of sessions from industry
leaders in dedicated Performance & Operations tracks. Use code vel09scf
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
