#3367: Introduce range iterator API
-------------------------------+--------------------------------------------
Reporter: garry.yao | Owner: fredck
Type: New Feature | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version:
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by garry.yao):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
The patch is quite good, while there's two issues:
1. The default '''guard''' function logic on L48 and L62 of document
boundary check is invalid.
1. The '''guard''' is not performed on specifically the boundary nodes,
Please check the attached TC for this problem.
1. Some iteration state could be further cached instead of been
calculated every iteration, e.g. L71-L82.
1. The walker should provide a 'reset' function to facilitate reusing of
the walker on same range.
--
Ticket URL: <http://dev.fckeditor.net/ticket/3367#comment:5>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations
Conference from O'Reilly Media. Velocity features a full day of
expert-led, hands-on workshops and two days of sessions from industry
leaders in dedicated Performance & Operations tracks. Use code vel09scf
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
