#3189: V3 : Padding block support
-------------------------------------+--------------------------------------
Reporter: fredck | Owner: garry.yao
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version:
Keywords: Confirmed 3.0RC Review- |
-------------------------------------+--------------------------------------
Changes (by fredck):
* keywords: Confirmed 3.0RC Review? => Confirmed 3.0RC Review-
Comment:
* In line 144, it would be better to use getElementsByTag. It would make
the loop faster, and the code simpler.
* In the for loop at line 145, there could be some coding style fixes.
* In line 153, instead of forcing the selection to be at the beginning of
the paragraph, it would be safer to have a bookmark to be selected. In
this way we avoid troubles in a theoretical case where the caret goes in
the middle of text.
* For getPrevious and getNext, it would be better to have a while loop to
check the nodes, instead of having recursive calls. Other than that, it
looks like the current implementation would not work if you have more than
one empty/spaces only nodes together.
* There is no really need to always extend the CKEDITOR.dtd for element
names tables. You can safely use a local variable for that, as this is
quite a specific case.
* I've noted that when inserting a table at the end of a text paragraph,
the padding node is not getting added. That's because the table is
actually splitting the paragraph, leaving an empty paragraph after it,
which is wrong.
--
Ticket URL: <http://dev.fckeditor.net/ticket/3189#comment:9>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
