#3618: List is not merged
-------------------------------+--------------------------------------------
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: Core : Styles | Version:
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by martinkou):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
Ok, almost there, but the code can be simplified. :-)
1. The stopFlag - this is actually my fault, you simply copied it over
from my old code. But it's not necessary. It can be replaced by a break.
2. mergeSibling is wrapped by CKEDITOR.tools.bind - but the only
reference to "this" inside is just this.type. So the CKEDITOR.tools.bind()
is actually quite wasteful. Instead, something like this would work with
less complexity:
{{{
var type = this.type;
function mergeSibling( rtl )
{
...
}
mergeSibling();
mergeSibling( true );
}}}
--
Ticket URL: <http://dev.fckeditor.net/ticket/3618#comment:4>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
