#3834: Context menu on table caption incorrect
-------------------------------+--------------------------------------------
 Reporter:  garry.yao          |       Owner:  tobiasz.cudnik
     Type:  Bug                |      Status:  assigned      
 Priority:  Normal             |   Milestone:  CKEditor 3.0  
Component:  UI : Context Menu  |     Version:                
 Keywords:  Confirmed Review-  |  
-------------------------------+--------------------------------------------
Changes (by fredck):

  * keywords:  Confirmed Review? => Confirmed Review-


Comment:

 - There is no need to create the "tagName" variable. It's used only once,
 so you can use element.getName() directly. You may do {{{contextMenuTags[
 element.getName() ]}}}.

  - The same thing for showContextMenu, we don't need a variable here. The
 condition can go straight into the if.

  - The contextMenuTags definition can be moved out, into the main
 anonymous function scope, so it's created only once.

  - There is an unwanted change in the changelog file at line 1.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/3834#comment:3>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
_______________________________________________
FCKeditor-Trac mailing list
FCKeditor-Trac@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to