#3925: FCKDialog.OpenDialog() - wrong variable mapping (parentWindow)
---------------------------+------------------------------------------------
Reporter: ivantcholakov | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone: FCKeditor 2.6.5
Component: UI : Dialogs | Version: FCKeditor 2.6.4
Keywords: |
---------------------------+------------------------------------------------
FCKEditor 2.6.4
This is not a "theoretical" note, I found this bug during development of
something.
See .../_source/internals/fckdialog.js
The parameter *parentWindow* in the function OpenDialog() declaration and
and the variable *topWindow* that sets a property of the dialogInfo object
are the
same thing actually. Only one should stay - parentWindow or topWindow.
Here is an example for a correction:
{{{
var FCKDialog = ( function()
{
...
return {
/**
* Opens a dialog window using the standard dialog
template.
*/
OpenDialog : function( dialogName, dialogTitle,
dialogPage, width, height, customValue, parentWindow, resizable )
{
...
// Setup the dialog info to be passed to the dialog.
var dialogInfo =
{
Title : dialogTitle,
Page : dialogPage,
Editor : window,
CustomValue : customValue, //
Optional
// -------------- A correction starts here
---------------------
//TopWindow : topWindow // Wrong
TopWindow : parentWindow // Correct
//
-------------------------------------------------------------
}
...
},
...
}}}
--
Ticket URL: <http://dev.fckeditor.net/ticket/3925>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
FCKeditor-Trac mailing list
FCKeditor-Trac@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
