#3783: Indenting commands in table cells creates collapsed paragraphs.
-----------------------+----------------------------------------------------
Reporter: martinkou | Owner: garry.yao
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version: SVN (CKEditor)
Keywords: Review- |
-----------------------+----------------------------------------------------
Changes (by fredck):
* keywords: Review? => Review-
Comment:
There are a few issues in the getNext and getPrevious changes:
* The "guard" name for the function is misleading, as it doesn't have the
same usage we have in the walker to "stop" the search. It instead acts
like a filter, and we have used the "evaluator" name for it in the walker.
The same name should be used here.
* The CKEDITOR.dom.element class is being used to transform the node when
passing it to the guard. We could have text nodes also there, so the
CKEDITOR.dom.node class should be used.
* The raw DOM node is being transformed twice, once when passing it to
the guard (evaluator) and again when returning the function result. We
should find a solution to make this transformation only once (maybe saving
the created object into a new variable).
Other than that, we must be sure that the changes in the function are not
impacting other parts of the code which are already using it.
--
Ticket URL: <http://dev.fckeditor.net/ticket/3783#comment:2>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
FCKeditor-Trac mailing list
FCKeditor-Trac@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
