#4058: [FF3,5] Sometimes WYSYWIG area is not editable
----------------------+-----------------------------------------------------
  Reporter:  arczi    |       Owner:                           
      Type:  Bug      |      Status:  reopened                 
  Priority:  Normal   |   Milestone:  CKEditor 3.0             
 Component:  General  |     Version:                           
Resolution:           |    Keywords:  Firefox Confirmed Review-
----------------------+-----------------------------------------------------
Changes (by fredck):

  * keywords:  Firefox Confirmed Review? => Firefox Confirmed Review-


Comment:

 I'm not able to reproduce it with proposed steps, but anyway, as I've said
 previously this is quite a rare and random issue. But the code looks good.

 There are a few simplifications we could do though:

 {{{
 iframe.on( 'load', function( ev )
         {
                 ev.removeListener();
                 !blockReady && contentDomReady( iframe.$.contentWindow );
         });
 }}}

 As you can see, {{{ev.removeListener()}}} is equivalent to the call you're
 proposing at line 269. It removed the executing function from the current
 event.

 Also, generally speaking, for code reduction, you can use 0/1 instead of
 false/true for internal flags like "blockReady", and you don't need to
 "initialize" it with false (or 0) because it will evaluate to false by
 default.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4058#comment:8>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
_______________________________________________
FCKeditor-Trac mailing list
FCKeditor-Trac@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to