#4048: Context submenu lacks uiColor
------------------------------------+---------------------------------------
Reporter: tobiasz.cudnik | Owner: tobiasz.cudnik
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.1
Component: General | Version:
Keywords: Kama Confirmed Review? |
------------------------------------+---------------------------------------
Changes (by tobiasz.cudnik):
* keywords: Kama Confirmed Review- => Kama Confirmed Review?
Comment:
Replying to [comment:7 garry.yao]:
> The patch works for me in all browsers, while there're some issues
noticed in codes:[[BR]]
> 1. L160 - L170 of skin.js could be merged into 'updateStylesheets'
function;[[BR]]
> 2. It's better to use RegExp for global replacement;[[BR]]
> 3. L176 - L192 should be merged within the guard condition at
L195.[[BR]]
1 and 2 are fixed.
Although 3 is incorrect, because UI color functionality should be
available independently from having a uiColor setting in a config. It can
be set using editor.setUiColor() in any moment and we shouldn't block it.
--
Ticket URL: <http://dev.fckeditor.net/ticket/4048#comment:8>
CKEditor <http://ckeditor.com/>
The text editor for Internet
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
FCKeditor-Trac mailing list
FCKeditor-Trac@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
