X-Comment-To: Eric Auer

Hi!

28-���-2002 21:44 [EMAIL PROTECTED] (Eric Auer) wrote to [EMAIL PROTECTED]:

EA> I hope you tried with Jeremies version 0.5c?

     First, sorry for my post - it was should be in private. Second - I try
to compile edition, which you ask, from your site. I know nothing about
Jeremie' version.

EA> All warnings are only
EA> a) about unused variables (should be easy to fix) and

     But their presents mean that those code was at least unclean or,
worser, contains bugs (when you use one variable instead other).

EA> b) about your "char" defaulting to "signed", while the author of
EA>    edit believes that it is "unsigned".

     Such assumption induces very annoying bugs!!!!! For example, if you use
char-variables as indexes and try to use value from second half of ASCII8,
you get wrong addressing!

        char cidx = 0x80;
        array[cidx];    // access to array[(int)-128], not array[128],
                        // as expected

All such places should be replaced by:

        unsigned char cidx ...
or
        array[(unsigned char)cidx]

from scratch!

EA> Hunting all those "char without unsigned" occurrences is probably
EA> quite a bit of work. See also my other mail for other bugs in 0.5c ...
EA> I would be happy if somebody could look into this, as I do not have the
EA> time to maintain EDIT - I only took the time to fix the bugs that I had
EA> explained in my original "bug bashing" mail, sorry.

     Sorry, but if I try to change something in EDIT, this ends in almost
complete rewrite such worse code. Don't sure if I ready to spend this for
EDIT. Ask simpler actions (advice, recompilation, etc) from me in this.

----------
list options/archives/etc.: http://www.topica.com/lists/fd-dev
unsubscribe: send blank email to: [EMAIL PROTECTED]

==^^===============================================================
This email was sent to: [email protected]

EASY UNSUBSCRIBE click here: http://topica.com/u/?bz8Rv5.bbRv4l.YXJjaGl2
Or send an email to: [EMAIL PROTECTED]

T O P I C A -- Register now to manage your mail!
http://www.topica.com/partner/tag02/register
==^^===============================================================

Reply via email to