Hello,
BER> I am pleased to announce that Free FDISK 1.1.3 is now available. The
BER> download link is at http://www.23cc.com/free-fdisk.
Brian, let me propose some optimization. Was (userint2.c):
______________O\_/_________________________________\_/O______________
/* Adjust maximum_partition_size_in_MB depending upon version */
if( (flags.version==FOUR) && (maximum_partition_size_in_MB > MAXFAT16NORM) )
maximum_partition_size_in_MB = MAXFAT16NORM;
if( (flags.version==FIVE) && (maximum_partition_size_in_MB > MAXFAT16NORM) )
maximum_partition_size_in_MB = MAXFAT16NORM;
if( (flags.version==SIX) && (maximum_partition_size_in_MB > MAXFAT16NORM) )
maximum_partition_size_in_MB = MAXFAT16NORM;
if( (flags.version==W95) && (maximum_partition_size_in_MB > MAXFAT16NORM) )
maximum_partition_size_in_MB = MAXFAT16NORM;
if( ( (flags.version==W95B) || (flags.version==W98) )
&& (flags.fat32==FALSE) && (maximum_partition_size_in_MB > MAXFAT16NORM) )
...
_____________________________________________________________________
O/~\ /~\O
Should be (more readable and easier to optimize by compiler):
______________O\_/_________________________________\_/O______________
/* Adjust maximum_partition_size_in_MB depending upon version */
if (max_partition_sz_MB > MAXFAT16NORM) {
if (flags.version == FOUR ||
flags.version == FIVE ||
flags.version == SIX ||
flags.version == W95 ||
((flags.version == W95B || flags.version == W98)
&& flags.fat32 == FALSE) ||
...
)
max_partition_sz_MB = MAXFAT16NORM;
}
_____________________________________________________________________
O/~\ /~\O
Also, if FOUR=4, FIVE=5, etc, then you may use less/greater operators (for
example, "flags.version >= 4 && flags.version <= 7").
Yes, it is quite possible to optimize the code like that, as well with
similar optimizations other places. At this time, though, I am going to
focus on fixing the bugs in order to ensure that by version 2.0 the program
is nearly bug-free. Any code segments that work are going to be left alone,
for now.
Regards,
Brian
----------
list options/archives/etc.: http://www.topica.com/lists/fd-dev
unsubscribe: send blank email to: [EMAIL PROTECTED]
==^================================================================
This email was sent to: [email protected]
EASY UNSUBSCRIBE click here: http://topica.com/u/?bz8Rv5.bbRv4l.YXJjaGl2
Or send an email to: [EMAIL PROTECTED]
T O P I C A -- Register now to manage your mail!
http://www.topica.com/partner/tag02/register
==^================================================================
