On Fri, Jul 06, 2007 at 03:32:17PM -0400, Jesse Keating wrote: > On Friday 06 July 2007 15:26:42 Michael E Brown wrote: > > Looking through your patch: > > > > +++ b/etc/defaults.cfg > > +config_opts['chroot_setup_cmd'] = 'groupinstall buildsys-build' > > > > This could be problematic for F7, F6, EPEL4/5 and others. > > > > I see two (three?) ways to handle this: > > > > 1) only add this line to -devel. > > > > 2) change the default in mock.py, and override F7/F6/EPEL4/EPEL5 > > configs. > > > > 3) add this line to -devel, and then migrate it to (2) above after a > > period of time (perhaps when we drop F6?) > > Yeah, I had this fleeting thought when I was doing it, then promptly forgot > about it. One of those days... > > I think 2 is probably safest, if people have locally modified their configs, > but I was also thinking we'd only make this change in rawhide, so it would > only be rawhide people who get it, not pushing it out to existing Fedora/RHEL > setups, so 3 is probably fine too.
I dont like to make changes specific to one distribution as that requires thought on my part and I am likely to mess it up, or forget about the distro specifics next update. The only solution in that case is to branch, which brings its own overhead. -- Michael -- Fedora-buildsys-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/fedora-buildsys-list
