On Thu, 15 Nov 2007 11:31:17 -0600, Michael E Brown wrote: > > For those, who test the cvs version of Plague 0.5.0 (tickets in bugzilla > > say so), there are at least two patches necessary to make it work on > > F7+F8 and with mock >= 0.8: > > > > http://mschwendt.fedorapeople.org/plague-0.5.0-fedora8.patch > > http://mschwendt.fedorapeople.org/plague-cvs-mock-0.8.patch > > Do we need to have a more-stable interface between mock and plague?
Dropping command-line args and changing status-file contents certainly is something that ought to be avoided after the gold release of the distribution. Fedora 7, on the other hand, broke Plague already with Python 2.5 and SQLite 3. With a working QA team, this would have been communicated/announced somewhere prior to F7. > I set up plague sometime in the distant, distant past and actually > hacked on it a bit. From what I remember, it had to read the state file > because the old version of mock could sometimes exit before it had > dropped the init state, or that mock could exit too quickly in the build > state. (I dont remember all the details...) Yes, sounds right. There's code in there that marks a build as failed despite a zero exit code returned by mock. Surprisingly, a few months ago (in September?) the old work-around broke the FE buildsys frequently because it read the state file not quickly/often enough and misinterpreted mock's exit. (most recent mock is not installed everywhere!) Nowadays, reading the state file is mostly for eye-candy, to display "prepping" instead of "building" for the long time it can take to complete a build root with remote repository downloads. The mock exit code is evaluated, and deleting a few more lines of code would get rid of what is left from the old work-around. > I think I have resolved most of those issues with mock 0.8.x. You should > be able to rely on the mock return code at least to tell you if it > succeeded or failed. See other reply in this thread. All that matters to me is to keep a pair of plague+mock working for e.g. CentOS4 or 5. -- Fedora-buildsys-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/fedora-buildsys-list
