Brian Kosick wrote:
OK I added
NOOP    = true
....
source:
        $(NOOP)

To my make file and koji builds fine...   Can I ask, what is the
conceptual reason to have the source target?

In Fedora CVS the upstream source tarball(s) are stored in a lookaside cache and only referenced from the CVS checkout. "make sources" pulls the tarball(s) into the checkout so "mock --buildsrpm" can use them to build the srpm without knowing the details of the source control layout. In your case, its fine to define the "sources" target as a noop. Calling "make sources" should probably be configurable at the tag level, but that feature hasn't been a priority.

Brian

On Fri, 2009-05-01 at 19:07 -0600, Brian Kosick wrote:
Hi All,

So I think that I have successfully upgraded koji from 1.2.6 to 1.3.1 by
doing this.  I just have a few issues to work out....

1)  install the koji 1.3.1 rpms
2)  update the db schema pgsql -h kojihost koji koji
< /usr/share/doc/koji-1.3.1/docs/schema-upgrade-1.2-1.3.sql
3) started kojid and kojira

When I did my first build, I got stuck with koji not having a mock group
srpm-build

I setup the mock group with
koji add-group dist-el5-build srpm-build
koji add-group-pkg dist-el5-build srpm-build pkg1 pkg2 pk3

I then added that group to my build dist with

koji call addGroupList dist-mxl-el5-build srpm-build

When I do a koji list-groups dist-mxl-el5-build i get
 koji list-groups dist-mxl-el5-build
build  [dist-mxl-el5-build]
<snip for brevity>
srpm-build  [dist-el5-build]
  automake: None, default  [dist-el5-build]
  bash: None, default  [dist-el5-build]
  buildsys-macros: None, default  [dist-el5-build]
  bzip2: None, default  [dist-el5-build]
  bzip2-devel: None, default  [dist-el5-build]
  coreutils: None, default  [dist-el5-build]
  cpio: None, default  [dist-el5-build]
  diffutils: None, default  [dist-el5-build]
  elfutils: None, default  [dist-el5-build]
  elfutils-libelf: None, default  [dist-el5-build]
  file: None, default  [dist-el5-build]
  gcc: None, default  [dist-el5-build]
  gcc-c++: None, default  [dist-el5-build]
  glibc: None, default  [dist-el5-build]
  glibc-common: None, default  [dist-el5-build]
  glibc-devel: None, default  [dist-el5-build]
  glibc-headers: None, default  [dist-el5-build]
  gzip: None, default  [dist-el5-build]
  info: None, default  [dist-el5-build]
  libselinux: None, default  [dist-el5-build]
  libsemanage: None, default  [dist-el5-build]
  libsepol: None, default  [dist-el5-build]
  libtool-ltdl: None, default  [dist-el5-build]
  make: None, default  [dist-el5-build]
  patch: None, default  [dist-el5-build]
  perl: None, default  [dist-el5-build]
  policycoreutils: None, default  [dist-el5-build]
  python: None, default  [dist-el5-build]
  readline: None, default  [dist-el5-build]
  readline-devel: None, default  [dist-el5-build]
  redhat-release: None, default  [dist-el5-build]
  redhat-rpm-config: None, default  [dist-el5-build]
  rpm-build: None, default  [dist-el5-build]
  rpm-libs: None, default  [dist-el5-build]
  sed: None, default  [dist-el5-build]
  selinux-policy: None, default  [dist-el5-build]
  shadow-utils: None, default  [dist-el5-build]
  sqlite: None, default  [dist-el5-build]
  tar: None, default  [dist-el5-build]
  unzip: None, default  [dist-el5-build]
  which: None, default  [dist-el5-build]
  zip: None, default  [dist-el5-build]
  zlib-devel: None, default  [dist-el5-build]

It appears that the repos have regenned and now when I try to do a
build, I'm getting

DEBUG util.py:280:  Executing command: ['make', 'sources']
DEBUG util.py:256:  make: *** No rule to make target `sources'.  Stop.
DEBUG util.py:319:  Child returncode was: 2

Has a new make command "sources" been created similar to "make srpm"?
If so what does it do and what does koji expect back?

Brian

--
Fedora-buildsys-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list

--
Fedora-buildsys-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list

--
Fedora-buildsys-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list

Reply via email to