Yes, that sounds right to me. The only reason I implied a difference between the hypothetical ExternalContentManager module and the default implementation was that, given other demands on the developers, the refactoring bit would allow Fedora implementations to take the solution up themselves in a cleanly compartmentalized way without requiring the default implementation to support file:// (, etc.) right away.
Added the improvement request as https://fedora-commons.org/jira/browse/FCREPO-485 - Ben On Fri, Apr 24, 2009 at 6:29 PM, Chris Wilper <[email protected]> wrote: > Hi Ben, > > On Fri, Apr 24, 2009 at 10:39 AM, Benjamin Armintor <[email protected]> > wrote: >> [...] As it stands in 3.1, the ValidationUtility class has a >> hard-coded rejection of file urls, and the DisseminationService class >> fetches external content via it's own WebClient (rather than using the >> ExternalContentManager). These two quirks prevent (as far as I can >> tell) an ExternalContentManager module from making non-http content >> available as datastreams. > > Agreed. > >> Would it be reasonable to split FCREPO-453 into 2 issues, so that the >> changes allowing an ExternalContentManager module to use non-http urls >> were separated from the actual implementation of such a module? > > So, just to make sure, the basic strategy you're thinking of is: > > First, refactor so that all datastream access (for content stored > outside fedora's control) goes consistently through > ExternalContentManager. This includes all runtime access to "R" and > "E" datastreams, as well as "M" datastreams when they are ingested by > reference. > > Next, add file:// (and potentially other) resolutions to an impl of > ExternalContentManager (why not DefaultExternalContentManager?), with > adequate administrative control over which dirs on the local machine > can be loaded from when the URL happens to be a file:/// one. > > Does this sound like the right split? If so, go ahead and add an > "improvement" task for the refactoring bit and then we can link it > to/from FCREPO-453 as a dependency. > > Thanks, > Chris > ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensign option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Fedora-commons-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fedora-commons-developers
