This sounds like a perfectly reasonable refactoring to me, and all of the
other discussion on this topic has shown that there are several options for
building on top of this down the road. I say go for it.

Bill


> First up, my initial proposal was just the factor out the way find the
> content models for a object into a method, rather than directly querying
> the relations. This should not in any way change the behaivour of
> Fedora. This would make ANY approach much simpler to implement later.
On Thu, Jul 9, 2009 at 11:39 AM, Chris Wilper <[email protected]> wrote:

> Hi Asger,
>
> On Wed, Jul 8, 2009 at 8:07 AM, Asger
> Blekinge-Rasmussen<[email protected]> wrote:
> > I have checked the Fedora code. There are 32 usages of the reference
> > Constants.MODEL.HAS_MODEL, to get the content models of a object. To me,
> > this feels like something that should be collected in a general method,
> > like getContentModels(pid) or the like.
> >
> > I would like to collect these usages, and make this general method, but
> > only if work like this would be interesting to Fedora. This is not
> > something that I would like to maintain myself, rather it should be
> > integrated into the Trunk when the code have been approved.
> >
> > If this is a feature the Fedora Developers would like, I will start work
> > on it soon.
>
> Speaking for myself, I think having this as a formal method would be
> useful in terms of simplifying the code.  I like having the generic
> method whereby any (e.g. extensible) relationship can be found, but if
> it's something that Fedora is aware of anyway, it seems fair to have a
> specific method for it.  I suspect you were thinking of extending the
> DigitalObject and DOReader interfaces?
>
> - Chris
>
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> Fedora-commons-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/fedora-commons-developers
>
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Fedora-commons-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fedora-commons-developers

Reply via email to