Jeremy Katz wrote:
On Mon, 2007-09-17 at 12:24 -0500, Douglas McClendon wrote:
ignore-deleted isn't an option worth keeping around

The main (albeit, not the best in the world :) reason that I've kept it
thus far is that it speeds up builds when just testing a livecd-creator
change.

But assuming the rest requires this,

It does require it. But in a prior version of the patch, I had both ignore-deleted and turbo-liveinst as options which were mutually exclusive. Thus if you really wanted to, you could keep the ignore-deleted option, as long as you made the genMinInstDelta call conditional upon it. Thus making the code in liveinst.sh that detects the absence of the delta technically not purely legacy.

The sentence at the top there does not reflect a strong opinion. I can see value in speeding up the build (~20-25% if I recall). But there is also some value in the removed complexity. Your call.

-dmc



looks fine and I'll just deal with
the time hit.  And maybe try to beat up some ext3 people about
implementing 'resize2fs --minimal' :)




Jeremy

--
Fedora-livecd-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list

--
Fedora-livecd-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list

Reply via email to