-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Richard W.M. Jones wrote:
> I'm still not sure I understand.  The libiconv.la file looks OK to me
> (see below).  And we routinely link against libiconv.

Sure, because you don't use the _mingw32_make and _mingw32_makeinstall
macro :)

http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/iconv/mingw32-iconv.spec

If you used it, it would be a different story.

Now, there is another library that does not respect destdir, and it is
libjpeg. I am attaching a patch to make it behave properly. It also
produces win32 executables without exe prefix so they will not be
considered by find-requires script. But that is easily fixed I guess by
either moving them or by patching the makefile.cfg more. I did the former.

Cheers

Fridrich

> # libiconv.la - a libtool library file
> # Generated by ltmain.sh - GNU libtool 1.5.24 (1.1220.2.455 2007/06/24 
> 02:13:29)
> #
> # Please DO NOT delete this file!
> # It is necessary for linking the library.
> 
> # The name that we can dlopen(3).
> dlname='../bin/libiconv-2.dll'
> 
> # Names of this library.
> library_names='libiconv.dll.a'
> 
> # The name of the static archive.
> old_library=''
> 
> # Libraries that this one depends upon.
> dependency_libs=''
> 
> # Version information for libiconv.
> current=6
> age=4
> revision=0
> 
> # Is this an already installed library?
> installed=yes
> 
> # Should we warn about portability when linking against -modules?
> shouldnotlink=no
> 
> # Files to dlopen/dlpreopen
> dlopen=''
> dlpreopen=''
> 
> # Directory that this library needs to be installed in:
> libdir='/usr/i686-pc-mingw32/sys-root/mingw/lib'
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAklKNMAACgkQu9a1imXPdA99GgCfTfiikuCrK5CQs4r3qUYiazuM
ccsAnjg9mrzhrVEvp1x257m/7CrTyWE+
=K5mE
-----END PGP SIGNATURE-----
--- jpeg-6b/makefile.cfg	2008-12-18 08:24:14.000000000 +0100
+++ jpeg-6b/makefile.cfg	2008-12-18 08:28:15.000000000 +0100
@@ -191,25 +191,29 @@
 # Installation rules:
 
 install: cjpeg djpeg jpegtran rdjpgcom wrjpgcom @FORCE_INSTALL_LIB@
-	$(INSTALL_PROGRAM) cjpeg $(bindir)/$(binprefix)cjpeg
-	$(INSTALL_PROGRAM) djpeg $(bindir)/$(binprefix)djpeg
-	$(INSTALL_PROGRAM) jpegtran $(bindir)/$(binprefix)jpegtran
-	$(INSTALL_PROGRAM) rdjpgcom $(bindir)/$(binprefix)rdjpgcom
-	$(INSTALL_PROGRAM) wrjpgcom $(bindir)/$(binprefix)wrjpgcom
-	$(INSTALL_DATA) $(srcdir)/cjpeg.1 $(mandir)/$(manprefix)cjpeg.$(manext)
-	$(INSTALL_DATA) $(srcdir)/djpeg.1 $(mandir)/$(manprefix)djpeg.$(manext)
-	$(INSTALL_DATA) $(srcdir)/jpegtran.1 $(mandir)/$(manprefix)jpegtran.$(manext)
-	$(INSTALL_DATA) $(srcdir)/rdjpgcom.1 $(mandir)/$(manprefix)rdjpgcom.$(manext)
-	$(INSTALL_DATA) $(srcdir)/wrjpgcom.1 $(mandir)/$(manprefix)wrjpgcom.$(manext)
+	mkdir -p $(DESTDIR)$(bindir)
+	$(INSTALL_PROGRAM) cjpeg $(DESTDIR)$(bindir)/$(binprefix)cjpeg
+	$(INSTALL_PROGRAM) djpeg $(DESTDIR)$(bindir)/$(binprefix)djpeg
+	$(INSTALL_PROGRAM) jpegtran $(DESTDIR)$(bindir)/$(binprefix)jpegtran
+	$(INSTALL_PROGRAM) rdjpgcom $(DESTDIR)$(bindir)/$(binprefix)rdjpgcom
+	$(INSTALL_PROGRAM) wrjpgcom $(DESTDIR)$(bindir)/$(binprefix)wrjpgcom
+	mkdir -p $(DESTDIR)$(mandir)
+	$(INSTALL_DATA) $(srcdir)/cjpeg.1 $(DESTDIR)$(mandir)/$(manprefix)cjpeg.$(manext)
+	$(INSTALL_DATA) $(srcdir)/djpeg.1 $(DESTDIR)$(mandir)/$(manprefix)djpeg.$(manext)
+	$(INSTALL_DATA) $(srcdir)/jpegtran.1 $(DESTDIR)$(mandir)/$(manprefix)jpegtran.$(manext)
+	$(INSTALL_DATA) $(srcdir)/rdjpgcom.1 $(DESTDIR)$(mandir)/$(manprefix)rdjpgcom.$(manext)
+	$(INSTALL_DATA) $(srcdir)/wrjpgcom.1 $(DESTDIR)$(mandir)/$(manprefix)wrjpgcom.$(manext)
 
 install-lib: libjpeg.$(A) install-headers
-	$(INSTALL_LIB) libjpeg.$(A) $(libdir)/$(binprefix)libjpeg.$(A)
+	mkdir -p $(DESTDIR)$(libdir)
+	$(INSTALL_LIB) libjpeg.$(A) $(DESTDIR)$(libdir)/$(binprefix)libjpeg.$(A)
 
 install-headers: jconfig.h
-	$(INSTALL_DATA) jconfig.h $(includedir)/jconfig.h
-	$(INSTALL_DATA) $(srcdir)/jpeglib.h $(includedir)/jpeglib.h
-	$(INSTALL_DATA) $(srcdir)/jmorecfg.h $(includedir)/jmorecfg.h
-	$(INSTALL_DATA) $(srcdir)/jerror.h $(includedir)/jerror.h
+	mkdir -p $(DESTDIR)$(includedir)
+	$(INSTALL_DATA) jconfig.h $(DESTDIR)$(includedir)/jconfig.h
+	$(INSTALL_DATA) $(srcdir)/jpeglib.h $(DESTDIR)$(includedir)/jpeglib.h
+	$(INSTALL_DATA) $(srcdir)/jmorecfg.h $(DESTDIR)$(includedir)/jmorecfg.h
+	$(INSTALL_DATA) $(srcdir)/jerror.h $(DESTDIR)$(includedir)/jerror.h
 
 clean:
 	$(RM) *.o *.lo libjpeg.a libjpeg.la
_______________________________________________
fedora-mingw mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/fedora-mingw

Reply via email to