Farkas Levente wrote:
> Daniel P. Berrange wrote:
>> On Wed, Dec 17, 2008 at 03:30:11PM +0100, Farkas Levente wrote:
>>> hi,
>>> i review this %_mingw32_make macro again. i can't find any better
>>> solution than implement it separately from %_mingw32_makeinstall.
>>> probably most of the case it's not used inside spec file, but even if i
>>> used it will work and use the runtime used directories (the only
>>> exception %_mingw32_make install, but there is the %_mingw32_makeinstall
>>> macro for this).
>>> it's working on fedora and rhel/centos too and mingw32-make outside of
>>> spec also working.
>> I still really don't think we should be passing all these args to
>> 'make' or 'make install' by default because its diverging from what
>> native builds do. For native builds '%__make' just expands to
>> '/usr/bin/make' and %configure is where all these paths are setup.
>> Only in a very few cases of broken apps not using autotools would
>> args to make be needed and they can be done in those app's .spec
>>
>> Daniel
>
> you've got right, the most important part here to set env variable
> setting and not make's args ie. it can be:
> %_mingw32_make %{_mingw32_env} ; make
> too.
> but the %_mingw32_makeinstall should have to remain this way (imho)
so here's my last patch in this series which removes the parameters from
make.
--
Levente "Si vis pacem para bellum!"
Index: mingw32-filesystem.spec
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-filesystem/devel/mingw32-filesystem.spec,v
retrieving revision 1.8
diff -u -r1.8 mingw32-filesystem.spec
--- mingw32-filesystem.spec 18 Dec 2008 10:53:30 -0000 1.8
+++ mingw32-filesystem.spec 29 Dec 2008 14:40:37 -0000
@@ -1,7 +1,7 @@
%define debug_package %{nil}
Name: mingw32-filesystem
-Version: 41
+Version: 42
Release: 1%{?dist}
Summary: MinGW base filesystem and environment
@@ -144,6 +144,9 @@
%changelog
+* Wed Dec 29 2008 Levente Farkas <[email protected]> - 42-1
+- Remove parameters from mingw32-make
+
* Wed Dec 17 2008 Levente Farkas <[email protected]> - 41-1
- Re-add mingw32-make
Index: mingw32-macros.mingw32
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-filesystem/devel/mingw32-macros.mingw32,v
retrieving revision 1.6
diff -u -r1.6 mingw32-macros.mingw32
--- mingw32-macros.mingw32 18 Dec 2008 10:53:30 -0000 1.6
+++ mingw32-macros.mingw32 29 Dec 2008 14:40:37 -0000
@@ -91,22 +91,6 @@
--mandir=%{_mingw32_mandir} \\\
--infodir=%{_mingw32_infodir}
-%_mingw32_make %{_mingw32_env} ; \
- make \\\
- prefix=%{_mingw32_prefix} \\\
- exec_prefix=%{_mingw32_exec_prefix} \\\
- bindir=%{_mingw32_bindir} \\\
- sbindir=%{_mingw32_sbindir} \\\
- sysconfdir=%{_mingw32_sysconfdir} \\\
- datadir=%{_mingw32_datadir} \\\
- includedir=%{_mingw32_includedir} \\\
- libdir=%{_mingw32_libdir} \\\
- libexecdir=%{_mingw32_libexecdir} \\\
- localstatedir=%{_mingw32_localstatedir} \\\
- sharedstatedir=%{_mingw32_sharedstatedir} \\\
- mandir=%{_mingw32_mandir} \\\
- infodir=%{_mingw32_infodir}
-
%_mingw32_makeinstall %{_mingw32_env} ; \
make \\\
prefix=%{?buildroot:%{buildroot}}%{_mingw32_prefix} \\\
@@ -124,3 +108,4 @@
infodir=%{?buildroot:%{buildroot}}%{_mingw32_infodir} \\\
install
+%_mingw32_make %{_mingw32_env} ; make
_______________________________________________
fedora-mingw mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/fedora-mingw
