Hello, I packaged OpenSC (http://www.opensc-project.org/) for cross compiling. I would like to get it included in Fedora, but before filing a review request I'd like to discuss a few points.
Spec URL: http://www.smartlink.ee/~kalev/mingw32-opensc.spec SRPM URL: http://www.smartlink.ee/~kalev/mingw32-opensc-0.11.7-1.fc11.src.rpm The resulting binaries work in Windows and the package successfully builds in Koji. 1) Is there any good reason to package libtool .la files? I've excluded them right now, but I saw some of them in the spec files from HG repo. 2) I couldn't get configure script to detect libiconv and added a workaround to the spec file: export ICONV_LIBS="-liconv" %{_mingw32_configure} Is it acceptable like that? 3) Should I mark %{_mingw32_sysconfdir}/opensc.conf as %config? Rpmlint spits out an error, because it doesn't like config files in /usr. 4) Rpmlint also says the following, but I guess it is harmless and can be ignored: mingw32-opensc.noarch: E: script-without-shebang /usr/i686-pc-mingw32/sys-root/mingw/sbin/opensc-install.bat mingw32-opensc.noarch: E: wrong-script-end-of-line-encoding /usr/i686-pc-mingw32/sys-root/mingw/sbin/opensc-install.bat mingw32-opensc.noarch: E: script-without-shebang /usr/i686-pc-mingw32/sys-root/mingw/bin/cardos-info.bat mingw32-opensc.noarch: E: wrong-script-end-of-line-encoding /usr/i686-pc-mingw32/sys-root/mingw/bin/cardos-info.bat 5) For some reason Firefox refuses to load opensc-pkcs11.dll as a security plugin. I have no idea how to resolve that but I think it isn't a showstopper. 6) I'd need a sponsor. Thanks for taking a look! -- Kalev Lember _______________________________________________ fedora-mingw mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/fedora-mingw
