On Sun, Nov 15, 2009 at 01:15:17PM +0100, Farkas Levente wrote: > On 11/15/2009 01:10 PM, Kalev Lember wrote: > > On 11/15/2009 01:08 PM, Farkas Levente wrote: > >> hi, > >> after reading this page > >> http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/mingw/README.chromium?revision=25199&view=markup > >> i think we should also include this patch, so i apply. > > > > Can you send the patch to pthreads-win32 mailing list [1] ? I took a > > quick look at the archives and there is some talk about 2.9.0 release > > with 64 bit Windows support. Would be nice if this patch was properly > > merged upstream and included in the new release. > > > > [1] http://sourceware.org/ml/pthreads-win32/ > > > > done.
I'm unhappy about the way this patch was added. The message (http://sourceware.org/ml/pthreads-win32/2009/msg00057.html) isn't clear what patch we're talking about. The real patch URL is: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/mingw/pthreads-w32.patch.txt?revision=16646&view=markup Patches should always go upstream first, and patches which aren't upstream yet should be documented in the spec file. Please add this documentation. https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment https://fedoraproject.org/wiki/Staying_close_to_upstream_projects Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top _______________________________________________ fedora-mingw mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/fedora-mingw
