Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lightning - GNU Lightning


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174952


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From [EMAIL PROTECTED]  2006-05-04 22:52 EST -------
rpmlint of lightning-1.2-3.i386.rpm:E: lightning no-binary
W: lightning devel-file-in-non-devel-package /usr/include/lightning/ppc/fp.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/ppc/funcs.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/core.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/ppc/core.h
W: lightning devel-file-in-non-devel-package 
/usr/include/lightning/sparc/funcs.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/fp.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/sparc/asm.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/ppc/asm.h
W: lightning devel-file-in-non-devel-package
/usr/include/lightning/i386/funcs.hW: lightning devel-file-in-non-devel-package
/usr/include/lightning/fp-common.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/i386/fp.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/i386/core.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/asm.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/i386/asm.h
W: lightning devel-file-in-non-devel-package
/usr/include/lightning/asm-common.hW: lightning devel-file-in-non-devel-package
/usr/include/lightning/core-common.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/funcs.h
W: lightning devel-file-in-non-devel-package
/usr/include/lightning/sparc/core.hW: lightning devel-file-in-non-devel-package
/usr/include/lightning/funcs-common.h
W: lightning devel-file-in-non-devel-package /usr/include/lightning/sparc/fp.h

These are all rather necessary for lightningize to lightningize something.
(Which it seemed to do successfully)

- package meets naming guidelines
- package meets packaging guidelines
- license is either GPL or LGPL both included and OK
- spec file legible, in am. english
- source matches upstream
- package compiles on FC5 (i386)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

This is something to add to the exclude x86_64 tracker.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to