Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: childplay

------- Additional Comments From [EMAIL PROTECTED]  2006-05-10 04:04 EST -------
Created an attachment (id=128836)
 --> (
Improved specfile

(In reply to comment #3)
> =========
> * Remove the single-quotes from the word 'suite' in the %description.

> * Package includes precompiled .pyo files.  These should probably be removed
>   and %ghosted.  The python guidelines[1] don't forbid them, but the python
>   package that I've seen always remove them.

> =======
> * Missing BR: desktop-file-utils


> =========
> * Why change /usr/bin/env python to /usr/bin/python?  The former will
>   pick up the first python executable in the path, which should be ok.
Because leaving it in  will make the package "Requires: /usr/bin/env" (rpmbuild
does this automaticly).

>   Even if you decide to change it, you should probably use %{_bindir}/python
>   instead of hardcoding /usr/bin in the sed command.

Configure bugmail:
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

Fedora-package-review mailing list

Reply via email to