Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190156 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From [EMAIL PROTECTED] 2006-05-20 05:06 EST ------- Needs work: * don't remove the buildroot in %prep (it breaks rpmbuild -bi --short-circuit) * do the sanity check in %check * it would be nice to add "|| :" at the end of the pear lines in the scriptlets, to make sure they won't return a failure and block the whole rpm transaction Minor: * Use "BuildArch:" instead of the full BuildArchitectures * Include the LICENCE as you did with php-pear-Mail. This is not a requirement though (it would be if the tarball shipped the license, which is not the case here) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
