Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2006-05-20 12:48 EST ------- Brian, are you reviewing this package ? Anyway here's my take at it (can't harm to have more people for review) Needs work: * BuildRequires: gettext is missing (required by the %find_lang macro) * /usr/share/info/dir is already owned by info, don't own it (put %{_datadir}/info/*.info.gz in %files for example) * Scriptlets: missing "install-info" in %post and %preun (in the wiki: ScriptletSnippets) Minor: * Version and Source1 are not properly lined-up (tabs instead of spaces) * Duplicate BuildRequires: gtk2-devel (by libglade2-devel) * At the end of ./configure, there is "Gnome support: no". Is that what you want ? From http://gnubiff.sourceforge.net, GNOME support could be useful. Perhaps a missing "BuildRequires: gnome-panel-devel" only ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
