Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rss-glx -- Really Slick Screensavers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188574





------- Additional Comments From [EMAIL PROTECTED]  2006-05-23 11:28 EST -------
Things are looking good now.  One new rpmlint warning (a line in %description is
too long).

However, I went to test this on a couple of i386 FC5 machines under KDE (so
rss-glx and rss-glx-kde are installed); the hacks display when run directly
(they open a small window in the background) but as KDE screensavers there are
some issues:

They show up at the bottom of the list, not filed under "OpenGL Screen Savers".
 Maybe they should have their own place in the hierarchy?  ("Really Slick Screen
Savers"?)  I think you do this by using X-KDE-Category= in the desktop file. 
It's probably also worth using X-KDE-Type=OpenGL as well.  But it looks like
you're just using the desktop files supplied by upstream here; I'm not sure if
it's worth it to hack them up.

The desktop files include "Actions=InWindow;Root" but then go on to define a
Setup action as well.

The setup page for each screensaver doesn't work at all unless you also install
rss-glx-screensaver.  Should this be a dependency of rss-glx-kde, or is
something else wrong?

The screensavers don't actually do anything; the "Test" button causes the
desktop to pause (system monitor and clock stop updating), but nothing is
actually displayed.  This happens on my home machine with binary Nvidia driver
and a machine here at work with a Radeon R200 (stock X driver).  Any ideas?

So at this point the form of the package is fine; you just need to fix that
overlong line in %description.  Unfortunately there's still some debugging to be
done.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to