Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xwrits https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193479 ------- Additional Comments From [EMAIL PROTECTED] 2006-05-29 14:01 EST ------- Hello Jeffrey, Not yet a proper review, but a couple of points: 1) Use the dist tag: Release: 1%{?dist} 2) Why not use %setup -q, as is standard 3) Use either $RPM_BUILD_ROOT or %{buildroot}, and do it consistently, don't mix and match - choose one and stick to it. 4) There should be a rm -rf $RPM_BUILD_ROOT at the beginning of %install 5) Consider using make %{?_smp_mflags} in build. Fix up these points and I'll run it through a mock build. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
