Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: knetstats https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193929 ------- Additional Comments From [EMAIL PROTECTED] 2006-06-08 07:27 EST ------- Couple of other points, it might be better to leave a blank line between different %changelog entries as it's easier on the eye and perhaps be a little more verbose as there's no mention of the other changes you made such as dropping gcc-c++ etc. I read somewhere on the wiki (although I can't find it at the mo), that patches should be named in the following way to avoid name collisions with other packages: name-version-description.patch For example: knetstats-1.5-rpathfix.patch It also advised against using the %{name} and %{version} macros here, particularly because the version indicates the version of the package this patch was introduced in, so for example if you were to upgrade to version 1.6, the patch would still be knetstats-1.5-rpathfix.patch, if it was still applicable. Anyway Hans will keep you right, he sponsored me too :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
