Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wireshark


           What    |Removed                     |Added
         AssignedTo|[EMAIL PROTECTED]          |[EMAIL PROTECTED]
OtherBugsDependingO|188265                      |188267
              nThis|                            |

------- Additional Comments From [EMAIL PROTECTED]  2006-06-09 14:05 EST -------
Radek, it would be helpful if the spec was linked to outside the srpm, just
makes reviews easier.

- buildroot should be 
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- You need Provides: ethereal to go along with your Obsoletes: for upgrade 
- Summary for wireshark-gnome, surely this is for more than just "Red Hat 
Gnome" ?
- Again, need Provides ethereal-gnome to go along w/ Obsoletes
- tshark -> tethereal link is well above the comment regarding it.
- files in /etc should be marked as config files, unless they are init scripts
- Desktop file present but not installed using desktop-file-install (which would
have a BuildRequires: on destkop-file-utils)

- If you take out the manual Requires, and let rpmbuild figure it out by soname
requirements, does it do the right thing?  THis is preferred method for 

Configure bugmail:
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Fedora-package-review mailing list

Reply via email to