Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eggdrop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194481 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED], | |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2006-06-14 10:50 EST ------- Looks like this came in right before the last backup before the disk crash. I'm re-adding the CCs I saw added to this bug; I'm quite interested in seeing this package get into Extras (I maintain a copy on the side). To summarize what happened (to any roving sponsors), Christopher Stone suggested a few changes, and Robert applied them. I suspect you'd be well-off removing the Requires: line, as it's technically redundant. Rpmbuild should (and, ultimately, is) able to resolve what the end package's dependencies are. I spun a test built without it and the resultant package depended on (among others): libdns.so.21 (which is provided by bind-lib) libtcl8.4.so (tcl) libz.so.1 (zlib) Anything else I see...nothing non-trivial. I'd personally change line 37 to "# Move modules into /usr/lib*" for honesty's sake. ;-) Not a full review, but then, I'm not a sponsor (sorry). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
