Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knetstats

------- Additional Comments From [EMAIL PROTECTED]  2006-06-16 14:12 EST -------
* rpmlint output is clean
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-x86_64
* BR: ok
* ocales properly handled
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* .desktop file as required and properly installed

MUST fix:
* Source0 is wrong (my fault) it should be:
* the common symlink is broken now due to your changes it now points to common,
 whereas it should point to ../common

(In reply to comment #17)
> Re: comment #15
> > And yes you need the gtk-update-icon-cache for KDE-apps too, because 
> >you want the icon to show properly in the gnome applications menu.
> FYI, only the 'touch' is strictly required for proper function (and adherance 
> to
> the fdo icon spec).  gtk-update-icon-cache only improves gtk2's icon loading
> performance.

Nope, when you install a package while running gnome and it doesn't properly
call gtk-update-icon-cache the icon doesnot show in the menu, atleast not during
that session. I've made that mistake myself enough times to know this.

Configure bugmail:
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

Fedora-package-review mailing list

Reply via email to