Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-apc


           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [EMAIL PROTECTED]  2006-06-19 10:51 EST -------

- rpmlint output:
W: php-pecl-apc incoherent-version-in-changelog 5.1.4_3.0.10-3 3.0.10-3.fc5
W: php-pecl-apc invalid-license PHP License
W: php-pecl-apc invalid-license PHP License
W: php-pecl-apc-debuginfo invalid-license PHP License

  The License is actually fine, and standard for PHP packages.
  The changelog entry needs fixing.

- package meets proposed PHP naming guidelines
- spec file name is correct
- license is PHP license, matches spec, text included
- package meets guidelines
- spec file written in English and is legible
- sources match upstream
- package builds ok in mock (FC-5 i386)
- BR's OK
- no locales, libraries, pkgconfigs, or subpackages to worry about
- not relocatable
- no directory ownership or permissions problems
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop file needed
- no scriptlets


- Fix version number in changelog entry, which will shut rpmlint up


- Why such a low value for apc.shm_size? This is the only value you've changed
  from the suggested values in the INSTALL file.
- What is "Provides: php-zend_extension" for?


- Include INSTALL as %doc; it includes useful end-user configuration info

Configure bugmail:
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

Fedora-package-review mailing list

Reply via email to