Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197476 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From [EMAIL PROTECTED] 2006-07-03 13:45 EST ------- Good: + Tarball in SRPM match with upstream. + Local build works fine. + License OK. + rpmlint of source RPM ok. + Mock build works fine on FC-5 as root. Bad: - No verbatin license in %doc stanza - I think the Group should be Development/Tools - Why you set CFLAGS, when no binary file will be created - rpmlint have the following complaints to the binary RPM. E: python-cvstoys non-executable-script /usr/lib/python2.4/site-packages/cvstoys/setup.py 0644 E: python-cvstoys non-executable-script /usr/lib/python2.4/site-packages/cvstoys/loginfo.py 0644 E: python-cvstoys non-executable-script /usr/lib/python2.4/site-packages/cvstoys/clients/words.py 0644 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
