Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: buildbot https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197565 ------- Additional Comments From [EMAIL PROTECTED] 2006-07-05 05:07 EST ------- A quick review for your package, based on differences from what I used in mine. 1. Group is valid, but I preferred Development/Build Tools 2. Source0: can't find it right now, but I read somewhere the download location from sourceforge pacakges should be set to http://download.sourceforge.net/ and not on of the mirrors 3. the require on python-abi seems to be redundant on FC4 onwards. If you are _not_ going to build this also for FC3, you can safely remove the Req and the second line on the spec. 4. I used Requires: python-twisted >= 1.3.0 (from the buildbot web site); it's probably safe to omit that unless some repo has an older version. 5. Requires: python-cvstoys is not _really_ required. I know we lack a "Enhances" tag, so that's your choice. I am generally against pushing in packages if not strictly necessary. 6. I think it's better to run %{__pyhton} instead of hardcoding python 7. if you feel comfortable with maintaining the full list of files, leave it that way. Otherwise, the I found the solution drafted at http://fedoraproject.org/wiki/Packaging/Python being quite smart None of this points seems to be blockers, but I hope you can consider them carefully. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
