Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197198 ------- Additional Comments From [EMAIL PROTECTED] 2006-07-06 06:36 EST ------- More issues: * plugins loaded twice After some look at the code and some testing I have found that all the plugins in the plugins directory are loaded, so they are loaded twice since they appear twice in the package... In my opinion either the *.so without version number should be removed, or they should be moved to *.so without version numbers. * a plugin is not functionnal **WARNING** Unable to load plugin /usr/lib/ntop/plugins/libxmldumpPlugin-3.2.so' **WARNING** Message is '/usr/lib/ntop/plugins/libxmldumpPlugin-3.2.so: undefined symbol: gdome_str_mkref' And there is also another error, but it may only happen on the first run **ERROR** LASTSEEN: Unable to open LsWatch database (/var/ntop/LsWatch.db)- the plugin will be disabled * many unneeded files in the docs: CONTENTS FILES ntop.txt README.Suse INSTALL BUILD-MinGW.txt BUILD-NTOP.txt ntop-autotools.* PORTING RedHat-rpmbuild-HOWTO.txt, and certainly DAG * should depend on logrotate * less rpmbuild warnings with the following line in %setup chmod -x docs/ntop-autotools.pdf *.c *.h plugins/*.c plugins/*.xml * you should remove /usr/lib/libntop.so, /usr/lib/libmyrrd.so and /usr/lib/libntopreport.so since there are no associated headers and also since they use -release, see below. * myrrd seems to be an old included version of rrdtools. It shouldn't be used but instead linked against the system rrd, unless there is a very good reason not to do so. * upstream uses the -release for libtool using the package version, this is wrong in general, since it trigggers a soname change even when the abi don't change, however those libraries are not meant to ne linked against, so if the *.so that don't have the release within their names are not distributed it is right. * The mechanisme described under PRIVACY NOTICE should be disabled in the default case (and reenabled with, for example --version-check) or completly disabled. * ntop doesn't seems to be interruptible by a control-C. It doesn't seems right to me but I may be wrong. Maybe for a similar reason, when killing ntop on the first run when ntop asks for a password, the console is broken. This last issue is not blocking the inclusion in extras in my opinion, it is more for upstream. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
