Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-POE-Component-Logger https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198023 ------- Additional Comments From [EMAIL PROTECTED] 2006-07-08 20:19 EST ------- (In reply to comment #1) > package is noarch > > => OPTIMIZE="%{optflags}" > is unused/superfluous. > > => This find also is very likely unnecessary: > find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';' > > Chris, Jason, this is a systematic bug in most (all) of Chris's perl packages. How is this a "bug"? It's part of the standard perl specfile template, doesn't conflict with any of the packaging guidelines, and it certainly isn't doing any harm. Is it worth 5-10 min of my time to to make sure that these lines are indeed not needed, and then another 5-10min for the reviewer to also 1) notice the deviation from the template, and 2) ensure that the packager's determination that the lines are superfluous and can be dropped is correct? If this is a "bug", then let's get it before the packaging committee and have the guidelines for perl packages changed to explicitly require excising those lines. Otherwise, let's call it "packager's preference/style"; and as they say in perl-land, TMTOWTDI :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
