Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eric: Python IDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186919


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From [EMAIL PROTECTED]  2006-07-27 00:04 EST -------
Everything's looking good now.  Did you see the fix to gen_sip_api.py that came
out July 11?

You can probably remove the comment with the link to the PyQt-qscintilla review.

I'm not sure about this; does PYTHONOPTIMIZE do the opposite of what I think it
does?

# generate .pyo files?  No, for now, it's fast enough as-is.  -- Rex
PYTHONOPTIMIZE=1; export PYTHONOPTIMIZE

rpmlint is complaining about spaces and tabs:
  W: eric mixed-use-of-spaces-and-tabs
Seems to be on the Name, Group, URL and Source lines.  Not an essential fix IMO,
but should be simple to fix.

* source files match upstream:
   2d2c4f85787b34671c76dea1436da8ae  eric-3.9.0.tar.gz
   fcea430a92e9d88089d91ce3099db282  gen_python_api_20050605.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* noarch package; no debuginfo.
X rpmlint complains about mixed spaces and tabs, plus some ignorable warnings.
* final provides and requires are sane:
   eric = 3.9.0-5.fc6
  =
   /bin/sh
   /usr/bin/env
   PyQt = 3.16
   PyQt-qscintilla
   python(abi) = 2.4
   python-abi = 2.4
* %check is not present; no test suite upstream.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to