Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: international-time (first package, seeking sponsor)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200422





------- Additional Comments From [EMAIL PROTECTED]  2006-07-27 14:08 EST -------
Hi Tim,

A couple of comments:

* The preferred value for the BuildRoot tag is
"%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)". This is not a
requirement for approval, though.

* desktop-file-install is usually (always?) called using "--vendor fedora" and
"--add-category X-Fedora".

* rpmlint has a few complaints (none of them serious):
   W: international-time summary-ended-with-dot
   W: international-time no-url-tag
   W: international-time no-documentation

* You can drop the 'pygtk2' requirement since 'pygtk2-libglade' already depends
on it. Also, it seems rpm already adds a dependency on "/usr/bin/python"
automatically so the 'python' requirement might be redundant... but I'm not
really sure.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to