Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: widelands - GPL Settlers II clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201418 ------- Additional Comments From [EMAIL PROTECTED] 2006-08-04 20:07 EST ------- There's a few things that need to be addressed before this can be approved. * Is there a reason you want to package files from CVS instead of the official file release? * Source1: is a tarball with a single .desktop file. Don't bother making a tarball for a single file. Just use "Source1: widelands.desktop". This will remove the need for the egregious tar command in %prep * Reduce the Summary: to a single sentence, without the leading 'A' * In your %install scriptlet, try using 'cp -a' instead of 'cp -r' to preserve timestamps * Remove the CVS directories in %prep, not in %install * Never refer to '/usr/src/redhat' in the spec file. It is highly unlikely that this directory will actually be used when the package is built. You can refer to your desktop file as %{SOURCED1} instead. * Don't use '/usr' in your build command. Use %{_prefix} instead. Also, 'share/widelands' should be '%{_datadir}/%{name}' I'd suggest reading through the packaging guidelines to become more familiar with the Fedora packaging rules: http://fedoraproject.org/wiki/Packaging/Guidelines -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
