Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459946


Lucian Langa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[email protected]    |[email protected]
               Flag|                            |fedora-review?




--- Comment #11 from Lucian Langa <[email protected]>  2009-01-06 15:25:40 EDT 
---
The compiler should be called with the full set of %{optflags} or the resulted
debuginfo package will be broken.
It looks like package does not honour external set of CXXFLAGS called by
rpmbuild:

+ CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic'
+ export CFLAGS
+ CXXFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic'
+ export CXXFLAGS
+ FFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-I/usr/lib64/gfortran/modules'
+ export FFLAGS
+ ./configure ....

so yo needs to be patched somehow.

Please also include COPYING file in the %doc section of the package.
It would be also nice to add README files, ChangeLog and AUTHORS.

Please bump the release version of the package for each set of modification.
Thank you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to