Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478412





--- Comment #3 from Fabian Affolter <fab...@bernewireless.net>  2009-01-10 
06:03:13 EDT ---
Thanks Patrick for your review.

(In reply to comment #1)
> [X]: The package must meet the Packaging Guidelines .
> 
> Fedora specific compiler options are not specified in the make

see below

> [X]: A package must not contain any duplicate files in the %files listing. 
> 
> Documentation duplicates the manpage and the info page.

fixed and removed the other useless stuff in this directory

> [?]: Large documentation files must go in a -doc subpackage. (The definition 
> of
> large is left up to the packager's best judgement, but is not restricted to
> size. Large can refer to either size or quantity).
> You might want to think of moving the documentation into a separate package,
> considering it is the bulk of the package size, the actual binary is only 
> 108KB
> while the documentation is about 1MB

Good point but making a new package for two file is a bit overkill from my
point of view. I removed *.texi files and now the complete package is 360 KB
(incl. documentation) 

(In reply to comment #2)
> Oops, forgot to tell you what compiler flags you need to add to make
> 
> $RPM_OPT_FLAGS/% or %{optflags} work :)
> 
> So you could do
> 
> make %{?_smp_mflags} %{optflags}

This will definitely not work...What flag/flags is/are not set properly?

+ unset DISPLAY
+ CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables'
+ export CFLAGS
+ CXXFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables'
+ export CXXFLAGS
+ FFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables'
+ export FFLAGS

Updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/mpop.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/mpop-1.0.16-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to