Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479515 Fabian Affolter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Fabian Affolter <[email protected]> 2009-01-10 12:47:56 EDT --- Just some comment on your spec file - The name of the spec file don't match guidelines https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name - The summary needs to be improved. It's not necessary to repeat the package name. - The license is wrong, check source header -> GPLv2+ - Your description looks very ugly. - Please preserve the time stamps in the install section if it's possible make DESTDIR=%{buildroot} INSTALL="install -p" install - There are translations... https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files - AUTHORS, COPYING, and so on must be include as %doc. https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#.25files_prefixes - You must install /verify the .desktop file https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files - You must use macros in the %files section https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros - Stuff from the doc directory in the source should marked as %doc in the package. - You should add a proper changelog entry. https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs >From my point of view this package should be named as 'musicorganizer'. The Mac version is called 'MusicOrganizer', the Debian version 'musicorganizer', and the Windows package 'Music.Organizer'. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
