Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472229


Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nob...@fedoraproject.org    |mtas...@ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #5 from Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp>  2009-01-11 
12:52:46 EDT ---
Well, for 5.1.0-2:

* Header files dependency:
  - Well, for example the installed QwtModule.sip contains:
----------------------------------------------------------------
    63  #include <sipQwtQwtArrayDouble.h>
    64  #include <sipQwtQwtArrayInt.h>
    65  #include <sipQwtQwtArrayQwtDoubleInterval.h>
    66  #include <sipQwtQwtArrayQwtDoublePoint.h>
-----------------------------------------------------------------
    However these header files are not installed. Would
    you check if these are ignored?

* About grace.py
  - Well, I checked this file again and actually this file is 
    executable, so it is more correct that this script should simply
    have 0755 permission (while for qplt.py it seems that
    this script cannot be executed directly).

Then:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to