Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052 --- Comment #5 from Jason Tibbitts <ti...@math.uh.edu> 2009-01-12 22:56:55 EDT --- Could you define "WinPE" in your %description? Just a parenthetical "Windows Preinstallation Environment" should be sufficient. Also, it needs a period at the end. You're missing Requires(preun): initscripts, and also a python dependency for your %post script. Does it make sense to include the sample .sif files? What about the manual from the upstream web site (http://oss.netfarm.it/guides/ris-linux.pdf)? This package is a little odd in that it installs as a service, but doesn't actually put any executables in %path. There isn't anything in the guidelines that would prohibit this as far as I can tell, but it seems a little admin-unfriendly. I don't know what to do about it; maybe a wrapper script that just calls "python /usr/share/ris-linux/binlsrv.py". But I'll leave that up to you. * source files match upstream. sha256sum: 196c7441f498154d1ae41ef4f1e5107296b7de39f345c763ccce2e913432ae19 ris-linux-0.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. X description could use a bit of work * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: config(ris-linux) = 0.4-3.fc11 ris-linux = 0.4-3.fc11 = /bin/sh /usr/bin/env chkconfig config(ris-linux) = 0.4-3.fc11 initscripts python(abi) >= 2.1 samba tftp-server * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files X scriptlet dependencies are off. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedoraemail@example.com http://www.redhat.com/mailman/listinfo/fedora-package-review