Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480103 Fabian Affolter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Fabian Affolter <[email protected]> 2009-01-15 06:54:17 EDT --- Just some quick comments on your spec file. - There is no need for '%define name bnIRC' and '%define version 1.1.1' because 'Name:' and 'Version:' can be used as macros later. https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros - Source0: should point to the upstream location of the tarball. https://fedoraproject.org/wiki/Packaging/SourceURL - 'BuildRoot:' please use on of the examples in the guidelines https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag - Your %description is too long. Didn't rpmlint complain about this? - Please preserve the time stamps in your %install section if possible make install DESTDIR=%{buildroot} INSTALL="install -p" - You are using '%post -p /sbin/ldconfig' and '%postun -p /sbin/ldconfig'. Aren't 'Requires(post): /sbin/ldconfig' and 'Requires(postun): /sbin/ldconfig' missing? - Please use one of the formating style from the guidelines for your %changelog entry https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
